+UPSND sent to poll activation status #10636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bqam-ublox, thank you for your changes. |
0xc0170
requested changes
May 23, 2019
|
@0xc0170 coding style fixed |
AriParkkila
reviewed
May 23, 2019
| @@ -192,14 +191,29 @@ bool UBLOX_AT_CellularContext::activate_profile(const char *apn, | |||
| if (_at.get_last_error() == NSAPI_ERROR_OK) { | |||
| // Activate, wait upto 30 seconds for the connection to be made | |||
| _at.set_at_timeout(30000); | |||
| _at.cmd_start("AT+UPSDA=0,3"); | |||
| _at.cmd_start("AT+UPSD=" PROFILE ",6,"); | |||
There was a problem hiding this comment.
Could you check UPSDA is dismissed here intentionally?
There was a problem hiding this comment.
This was a mistake! Thanks for pointing out, corrected.
AriParkkila
approved these changes
May 23, 2019
0xc0170
approved these changes
May 23, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the context activation using the +UPSND AT command. Previously, the context status was updated immediately after activating the context (without verifying if it was activated successfully).
+UPSND command responds with the status of the context activation. The status is polled every 5s with a max timeout of 180s.
Pull request type
Reviewers
Release Notes